icmp: randomize the global rate limiter
authorEric Dumazet <edumazet@google.com>
Thu, 15 Oct 2020 18:42:00 +0000 (11:42 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:06:59 +0000 (09:06 +0100)
commite1b8b57623521b7f4974476a20bd6ff971fde6c4
tree345c614a762eaaca1596a398ad77e816d973120c
parentc042da4b2987e42e4365134edb9106c5ee1dc10c
icmp: randomize the global rate limiter

[ Upstream commit b38e7819cae946e2edf869e604af1e65a5d241c5 ]

Keyu Man reported that the ICMP rate limiter could be used
by attackers to get useful signal. Details will be provided
in an upcoming academic publication.

Our solution is to add some noise, so that the attackers
no longer can get help from the predictable token bucket limiter.

Fixes: 4cdf507d5452 ("icmp: add a global rate limitation")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Keyu Man <kman001@ucr.edu>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Documentation/networking/ip-sysctl.txt
net/ipv4/icmp.c