serial: 8250: Don't service RX FIFO if interrupts are disabled
authorVignesh R <vigneshr@ti.com>
Thu, 8 Feb 2018 12:55:41 +0000 (18:25 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 May 2018 14:18:00 +0000 (16:18 +0200)
commite10bbc220e1a37ce0292217dbbc98773b330b525
tree9060e731b78f918773c2e5e1a47bfc0435cdffd4
parent1c447ea137037fb3dae452efc28f607020df76d0
serial: 8250: Don't service RX FIFO if interrupts are disabled

[ Upstream commit 2e9fe539108320820016f78ca7704a7342788380 ]

Currently, data in RX FIFO is read based on UART_LSR register state even
if RDI and RLSI interrupts are disabled in UART_IER register.
This is because when IRQ handler is called due to TX FIFO empty event,
RX FIFO is serviced based on UART_LSR register status instead of
UART_IIR status. This defeats the purpose of disabling UART RX
FIFO interrupts during throttling(see, omap_8250_throttle()) as IRQ
handler continues to drain UART RX FIFO resulting in overflow of buffer
at tty layer.
Fix this by making sure that driver drains UART RX FIFO only when
UART_IIR_RDI is set along with UART_LSR_BI or UART_LSR_DR bits.

Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_port.c