[SKBUFF]: Merge common code between copy_skb_header and skb_clone
authorHerbert Xu <herbert@gondor.apana.org.au>
Sun, 14 Oct 2007 07:37:30 +0000 (00:37 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Mon, 15 Oct 2007 19:26:24 +0000 (12:26 -0700)
commitdec18810c52ed564c1aedc7f93dbf278b7fdf6d5
treea703e90e3dc901fdb55ada142011f1815189b0b8
parentf4921aff5b174349bc36551f142a5dbac782ea3f
[SKBUFF]: Merge common code between copy_skb_header and skb_clone

This patch creates a new function __copy_skb_header to merge the common
code between copy_skb_header and skb_clone.  Having two functions which
are largely the same is a source of wasted labour as well as confusion.

In fact the tc_verd stuff is almost certainly a bug since it's treated
differently in skb_clone compared to the callers of copy_skb_header
(skb_copy/pskb_copy/skb_copy_expand).

I've kept that difference in tact with a comment added asking for
clarification.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/skbuff.c