net_sched: make cls_ops->change and cls_ops->delete optional
authorPatrick McHardy <kaber@trash.net>
Fri, 4 Sep 2009 06:41:16 +0000 (06:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 6 Sep 2009 09:07:02 +0000 (02:07 -0700)
commitde6d5cdf881353f83006d5f3e28ac4fffd42145e
treeedc032e4d0a868578780facdd28fb0ee277aadc3
parent71ebe5e91947392bc276af713827eab12b6db8e4
net_sched: make cls_ops->change and cls_ops->delete optional

Some schedulers don't support creating, changing or deleting classes.
Make the respective callbacks optionally and consistently return
-EOPNOTSUPP for unsupported operations, instead of currently either
-EOPNOTSUPP, -ENOSYS or no error.

In case of sch_prio and sch_multiq, the removed operations additionally
checked for an invalid class. This is not necessary since the class
argument can only orginate from ->get() or in case of ->change is 0
for creation of new classes, in which case ->change() incorrectly
returned -ENOENT.

As a side-effect, this patch fixes a possible (root-only) NULL pointer
function call in sch_ingress, which didn't implement a so far mandatory
->delete() operation.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_api.c
net/sched/sch_ingress.c
net/sched/sch_multiq.c
net/sched/sch_prio.c
net/sched/sch_red.c
net/sched/sch_sfq.c
net/sched/sch_tbf.c