sky2: don't do GRO on second port
authorstephen hemminger <shemminger@vyatta.com>
Mon, 30 Aug 2010 07:51:17 +0000 (07:51 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Sep 2010 21:49:33 +0000 (14:49 -0700)
commitde6be6c1f77798c4da38301693d33aff1cd76e84
treef00cedd75ddae577847cd334f099f3560fb5cced
parent750e9fad8c7f44e0005ffb7195f72dd76978c2cf
sky2: don't do GRO on second port

There's something very important I forgot to tell you.
 What?

 Don't cross the GRO streams.
 Why?

 It would be bad.
 I'm fuzzy on the whole good/bad thing. What do you mean, "bad"?

 Try to imagine all the Internet as you know it stopping instantaneously
  and every bit in every packet swapping at the speed of light.
 Total packet reordering.
 Right. That's bad. Okay. All right. Important safety tip. Thanks, Hubert

The simplest way to stop this is just avoid doing GRO on the second port.
Very few Marvell boards support two ports per ring, and GRO is just
an optimization.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/sky2.c