USB: serial: kl5kusb105: abort on open exception path
authorPan Bian <bianpan2016@163.com>
Tue, 29 Nov 2016 15:55:02 +0000 (16:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Jan 2017 10:22:47 +0000 (11:22 +0100)
commitde2cf4998a52fd6e0a0273977775817c48afe036
tree40ffd1c36019ce7cc3ae379c03746e8151cefa46
parentf5531856c2c7763f8880fc4319830cc59cf1c8c3
USB: serial: kl5kusb105: abort on open exception path

commit 3c3dd1e058cb01e835dcade4b54a6f13ffaeaf7c upstream.

Function klsi_105_open() calls usb_control_msg() (to "enable read") and
checks its return value. When the return value is unexpected, it only
assigns the error code to the return variable retval, but does not
terminate the exception path. This patch fixes the bug by inserting
"goto err_generic_close;" when the call to usb_control_msg() fails.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Pan Bian <bianpan2016@163.com>
[johan: rebase on prerequisite fix and amend commit message]
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/kl5kusb105.c