qlcnic: fix a return in qlcnic_dcb_get_capability()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 19 Oct 2018 20:11:11 +0000 (23:11 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 1 Dec 2019 08:13:44 +0000 (09:13 +0100)
commitdd99b3b9d60e79c068e0f37c8c3e2fa00a66c123
tree252bb749a7a4a1a63e888695bd9b5d76344c992a
parenta8ab2f7969b034a810d295e2514626c504ee9d89
qlcnic: fix a return in qlcnic_dcb_get_capability()

[ Upstream commit c94f026fb742b2d3199422751dbc4f6fc0e753d8 ]

These functions are supposed to return one on failure and zero on
success.  Returning a zero here could cause uninitialized variable
bugs in several of the callers.  For example:

    drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority()
    error: uninitialized symbol 'caps'.

Fixes: 48365e485275 ("qlcnic: dcb: Add support for CEE Netlink interface.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c