ext4: fix use-after-iput when fscrypt contexts are inconsistent
authorEric Biggers <ebiggers@google.com>
Thu, 2 Feb 2017 02:07:11 +0000 (21:07 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 2 Feb 2017 02:07:11 +0000 (21:07 -0500)
commitdd01b690f8f4b1e414f89e5a9a5326bf720d6652
tree9a6e1087c7d858d0a747956bfca32292413a11fd
parentdbfcef6b0f4012c57bc0b6e0e660d5ed12a5eaed
ext4: fix use-after-iput when fscrypt contexts are inconsistent

In the case where the child's encryption context was inconsistent with
its parent directory, we were using inode->i_sb and inode->i_ino after
the inode had already been iput().  Fix this by doing the iput() in the
correct places.

Note: only ext4 had this bug, not f2fs and ubifs.

Fixes: d9cdc9033181 ("ext4 crypto: enforce context consistency")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/namei.c