drbd: add comment why we want to first call local-io-error, then send state
authorLars Ellenberg <lars.ellenberg@linbit.com>
Thu, 19 Feb 2015 12:43:55 +0000 (13:43 +0100)
committerJens Axboe <axboe@fb.com>
Wed, 25 Nov 2015 16:22:01 +0000 (09:22 -0700)
commitdc99562a48f39db4be0f9195137ec6f5350baf19
tree1c219a86434d6f75db0a37252ffba39934963ce7
parent9bd2eb2c98239c465a51571b5c2a465a2ff7d70b
drbd: add comment why we want to first call local-io-error, then send state

Even though we really want to get the state information about our bad
disk to the peer as soon as possible, it is useful to first call the
local-io-error handler.

People may chose to hard-reset the box from there.
If that looks and behaves exactly like a "regular node crash", without
bumping the data generation UUIDs on the peer in between, it makes it
easier to deal with.

If you intend to return from the local-io-error handler, then better
return as quickly as possible to avoid triggering other timeouts.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/drbd/drbd_state.c