tracing: Return error if ftrace_trace_arrays list is empty
authorYoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Thu, 5 Jun 2014 22:35:17 +0000 (07:35 +0900)
committerSteven Rostedt <rostedt@goodmis.org>
Fri, 6 Jun 2014 08:47:46 +0000 (04:47 -0400)
commitdc81e5e3abb9f98a3cb6f269c0bee595b2c1235d
tree7a61f4727ce4bcee34e8ec808b5c51e2510d9a9a
parent34839f5a69989c0ee48386a788fba37eb75910f7
tracing: Return error if ftrace_trace_arrays list is empty

ftrace_trace_arrays links global_trace.list. However, global_trace
is not added to ftrace_trace_arrays if trace_alloc_buffers() failed.
As the result, ftrace_trace_arrays becomes an empty list. If
ftrace_trace_arrays is an empty list, current top_trace_array() returns
an invalid pointer. As the result, the kernel can induce memory corruption
or panic.

Current implementation does not check whether ftrace_trace_arrays is empty
list or not. So, in this patch, if ftrace_trace_arrays is empty list,
top_trace_array() returns NULL. Moreover, this patch makes all functions
calling top_trace_array() handle it appropriately.

Link: http://lkml.kernel.org/p/20140605223517.32311.99233.stgit@yunodevel
Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.h
kernel/trace/trace_events.c