perf hists browser: Fix seg fault when annotate null symbol
authorLin Ming <ming.m.lin@intel.com>
Fri, 8 Apr 2011 06:31:26 +0000 (14:31 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 15 Apr 2011 15:51:49 +0000 (12:51 -0300)
commitdb9a9cbc8142eed008e242e389938689c6feb1ba
treecb4311d8906cba65b0de09c18bd881986d0c2ed5
parente566b76ed30768140df8f0023904aed5a41244f7
perf hists browser: Fix seg fault when annotate null symbol

In hists browser, press hotkey 'a' to annotate current symbol.

Now it causes segment fault if 'a' is pressed on a null symbol.

Here are 2 small bugs:
- In perf_evsel__hists_browse, the condition check after 'a' is pressed
  is not correct, we should check ->sym instead of ->map.
- In symbol__tui_annotate we must check whether sym is NULL or not
  before getting annotation structure.

This patch fixes above 2 small bugs.

Link: http://lkml.kernel.org/r/1302244286.4106.36.camel@minggr.sh.intel.com
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/ui/browsers/annotate.c
tools/perf/util/ui/browsers/hists.c