target: Fail on non zero scsi_status in compare_and_write_callback
authorNicholas Bellinger <nab@linux-iscsi.org>
Wed, 2 Oct 2013 00:04:40 +0000 (17:04 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Thu, 3 Oct 2013 11:24:07 +0000 (04:24 -0700)
commitdb60df88ec39715fc3fb2a846cf35837e074c11d
tree12b29dda83448869226325fad6ea67e2882c6b0b
parentd8855c154e748c9ccd7c78e6478560ed61438e7d
target: Fail on non zero scsi_status in compare_and_write_callback

This patch addresses a bug for backends such as IBLOCK that perform
asynchronous completion via transport_complete_cmd(), that will call
target_complete_failure_work() -> transport_generic_request_failure(),
upon exception status and invoke cmd->transport_complete_callback()
-> compare_and_write_callback() incorrectly during the failure case.

It adds a check for a non zero se_cmd->scsi_status within the first
invocation of compare_and_write_callback(), and will jump to out plus
up se_device->caw_sem before exiting the callback.

Reported-by: Thomas Glanzmann <thomas@glanzmann.de>
Tested-by: Thomas Glanzmann <thomas@glanzmann.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_sbc.c