ext4: do not delete unlinked inode from orphan list on failed truncate
authorJan Kara <jack@suse.cz>
Fri, 24 May 2019 03:35:28 +0000 (23:35 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 May 2019 13:47:10 +0000 (06:47 -0700)
commitdb30e95da574aed2f7a9b3defa68d01e6fe02bd6
tree4f6e2583b9a7e2d944ca37f4aaf32c1c86fd55b8
parentf77efdaa77b777e9b983696fa5a4a29a2768d6dd
ext4: do not delete unlinked inode from orphan list on failed truncate

commit ee0ed02ca93ef1ecf8963ad96638795d55af2c14 upstream.

It is possible that unlinked inode enters ext4_setattr() (e.g. if
somebody calls ftruncate(2) on unlinked but still open file). In such
case we should not delete the inode from the orphan list if truncate
fails. Note that this is mostly a theoretical concern as filesystem is
corrupted if we reach this path anyway but let's be consistent in our
orphan handling.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/inode.c