irqflags: Fix (at least latent) code generation issue
authorJan Beulich <JBeulich@suse.com>
Tue, 20 Jan 2015 13:00:46 +0000 (13:00 +0000)
committerIngo Molnar <mingo@kernel.org>
Thu, 19 Feb 2015 00:08:42 +0000 (01:08 +0100)
commitdb2dcb4f91d5fec5c346a82c309187ee821e2495
tree3350f0de6c332492f54e3d8a08b490dc812070ed
parent02cea3958664723a5d2236f0f0058de97c7e4693
irqflags: Fix (at least latent) code generation issue

The conditional in local_irq_restore() otherwise can cause code
bloat (the if and else blocks may get translated into separate
code paths despite the generated code being identical, dependent
on compiler internal heuristics). Note that this adjustment gets
the code in sync with the comment preceding it (which was
slightly wrong from at least from 2.6.37 onwards).

The code bloat was observed in reality with an experimental x86
patch.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/54BE5F8E02000078000570A7@mail.emea.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/irqflags.h