packet: only test po->has_vnet_hdr once in packet_snd
authorWillem de Bruijn <willemb@google.com>
Tue, 26 Sep 2017 16:20:17 +0000 (12:20 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Sep 2017 17:24:31 +0000 (10:24 -0700)
commitda7c9561015e93d10fe6aab73e9288e0d09d65a6
treef7b60e018e78a975e17e327f614e6dddb07ea306
parent4971613c1639d8e5f102c4e797c3bf8f83a5a69e
packet: only test po->has_vnet_hdr once in packet_snd

Packet socket option po->has_vnet_hdr can be updated concurrently with
other operations if no ring is attached.

Do not test the option twice in packet_snd, as the value may change in
between calls. A race on setsockopt disable may cause a packet > mtu
to be sent without having GSO options set.

Fixes: bfd5f4a3d605 ("packet: Add GSO/csum offload support.")
Signed-off-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/packet/af_packet.c