Staging: most: hdm-dim2: constify attribute_group structures
authorBhumika Goyal <bhumirks@gmail.com>
Thu, 29 Sep 2016 14:58:31 +0000 (20:28 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 2 Oct 2016 15:24:00 +0000 (17:24 +0200)
commitd983c597757883496a9e4956e308395f8ac53bf0
treea7e446cc3f456c610c70516d7dbdb7d382f24616
parent4ee4b9da2b01421521f6ee434e7d6098aecedbdf
Staging: most: hdm-dim2: constify attribute_group structures

Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property can also be made constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1,e2;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text    data     bss     dec     hex filename
    509     160       0     669     29d
drivers/staging/most/hdm-dim2/dim2_sysfs.o

File size after:
   text    data     bss     dec     hex filename
    565      96       0     661     295
drivers/staging/most/hdm-dim2/dim2_sysfs.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/most/hdm-dim2/dim2_sysfs.c