nfsd: don't thrash the cl_lock while freeing an open stateid
authorJeff Layton <jlayton@primarydata.com>
Wed, 30 Jul 2014 01:34:42 +0000 (21:34 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 31 Jul 2014 18:20:31 +0000 (14:20 -0400)
commitd83017f94c290c56010e194cdbc45e59894ccae2
treeae43a5fec20167258716bf8344e03c30006e0084
parent2c41beb0e5cf22fe3ab4c4adc3cedd5f732b2a7e
nfsd: don't thrash the cl_lock while freeing an open stateid

When we remove the client_mutex, we'll have a potential race between
FREE_STATEID and CLOSE.

The root of the problem is that we are walking the st_locks list,
dropping the spinlock and then trying to release the persistent
reference to the lockstateid. In between, a FREE_STATEID call can come
along and take the lock, find the stateid and then try to put the
reference. That leads to a double put.

Fix this by not releasing the cl_lock in order to release each lock
stateid. Use put_generic_stateid_locked to unhash them and gather them
onto a list, and free_ol_stateid_reaplist to free any that end up on the
list.

Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c