net: Use ns_capable_noaudit() when determining net sysctl permissions
authorTyler Hicks <tyhicks@canonical.com>
Fri, 3 Jun 2016 04:43:22 +0000 (23:43 -0500)
committerJames Morris <james.l.morris@oracle.com>
Mon, 6 Jun 2016 10:16:22 +0000 (20:16 +1000)
commitd6e0d306449bcb5fa3c80e7a3edf11d45abf9ae9
treec340f613680154bf751e707de302ae7b2a52d30b
parent98f368e9e2630a3ce3e80fb10fb2e02038cf9578
net: Use ns_capable_noaudit() when determining net sysctl permissions

The capability check should not be audited since it is only being used
to determine the inode permissions. A failed check does not indicate a
violation of security policy but, when an LSM is enabled, a denial audit
message was being generated.

The denial audit message caused confusion for some application authors
because root-running Go applications always triggered the denial. To
prevent this confusion, the capability check in net_ctl_permissions() is
switched to the noaudit variant.

BugLink: https://launchpad.net/bugs/1465724
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
net/sysctl_net.c