xen-blkback: only read request operation from shared ring once
authorRoger Pau Monné <roger.pau@citrix.com>
Tue, 3 Nov 2015 16:34:09 +0000 (16:34 +0000)
committerWilly Tarreau <w@1wt.eu>
Mon, 6 Feb 2017 22:32:29 +0000 (23:32 +0100)
commitd6837064ef1e8d3edca4d4848e12e4e905f4039a
treed7ff62ef5aa10f06175eb16e813160a3fb2d8baa
parent67434d33afc97f2f99b8889c110d190dedefda44
xen-blkback: only read request operation from shared ring once

commit 1f13d75ccb806260079e0679d55d9253e370ec8a upstream.

A compiler may load a switch statement value multiple times, which could
be bad when the value is in memory shared with the frontend.

When converting a non-native request to a native one, ensure that
src->operation is only loaded once by using READ_ONCE().

This is part of XSA155.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "Jan Beulich" <JBeulich@suse.com>
[wt: s/READ_ONCE/ACCESS_ONCE for 3.10]
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/block/xen-blkback/common.h