kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit
authorSean Young <sean@mess.org>
Sun, 8 Oct 2017 16:12:16 +0000 (12:12 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Jul 2021 10:48:12 +0000 (12:48 +0200)
commitd63af6c931f73b4597e37816ed4e77ee690ada82
treec0939eee63e049057d6d815ccbed4d17b6fa614e
parentfb2479ddfb0b1eae0d60868aa444aace4ce6287c
kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

commit 8a866fee3909c49738e1c4429a8d2b9bf27e015d upstream.

If you try to store u64 in a kfifo (or a struct with u64 members),
then the buf member of __STRUCT_KFIFO_PTR will cause 4 bytes
padding due to alignment (note that struct __kfifo is 20 bytes
on 32 bit).

That in turn causes the __is_kfifo_ptr() to fail, which is caught
by kfifo_alloc(), which now returns EINVAL.

So, ensure that __is_kfifo_ptr() compares to the right structure.

Signed-off-by: Sean Young <sean@mess.org>
Acked-by: Stefani Seibold <stefani@seibold.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Matthew Weber <matthew.weber@collins.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/kfifo.h