ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 26 Jul 2019 02:14:42 +0000 (10:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 10:47:47 +0000 (12:47 +0200)
commitd43391797c18b0ca4cf3773cf2c99d712501918c
tree5e334e1c60ab13b4c7e8f614313ac0e0c2295b56
parentfb840da92a23f91582f1f5c63a1cbb711ec2d496
ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()

[ Upstream commit 2127c01b7f63b06a21559f56a8c81a3c6535bd1a ]

In build_adc_controls(), there is an if statement on line 773 to check
whether ak->adc_info is NULL:
    if (! ak->adc_info ||
        ! ak->adc_info[mixer_ch].switch_name)

When ak->adc_info is NULL, it is used on line 792:
    knew.name = ak->adc_info[mixer_ch].selector_name;

Thus, a possible null-pointer dereference may occur.

To fix this bug, referring to lines 773 and 774, ak->adc_info
and ak->adc_info[mixer_ch].selector_name are checked before being used.

This bug is found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/i2c/other/ak4xxx-adda.c