nfp: refuse offloading filters that redirects to upper devices
authorPieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Wed, 25 Oct 2017 18:47:05 +0000 (11:47 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Oct 2017 01:07:14 +0000 (10:07 +0900)
commitd309ae5c6a00648198d1932e6db483d612c2e260
treee0fe91c236c7271ba1f20ff62346f83eabc1f2d0
parent0f5da659d8f1810f44de14acf2c80cd6499623a0
nfp: refuse offloading filters that redirects to upper devices

Previously we did not ensure that a netdev is a representative netdev
before dereferencing its private data. This can occur when an upper netdev
is created on a representative netdev. This patch corrects this by first
ensuring that the netdev is a representative netdev before using it.
Checking only switchdev_port_same_parent_id is not sufficient to ensure
that we can safely use the netdev. Failing to check that the netdev is also
a representative netdev would result in incorrect dereferencing.

Fixes: 1a1e586f54bf ("nfp: add basic action capabilities to flower offloads")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/flower/action.c