arm64: remove irq_count and do_softirq_own_stack()
authorJames Morse <james.morse@arm.com>
Fri, 18 Dec 2015 16:01:47 +0000 (16:01 +0000)
committerWill Deacon <will.deacon@arm.com>
Mon, 21 Dec 2015 17:26:01 +0000 (17:26 +0000)
commitd224a69e3d80fe08f285d1f41d21b590bae4fa9f
tree714dfa475b1e358c18285af1d809e08fc7e6f790
parent66b3923a1a0f77a563b43f43f6ad091354abbfe9
arm64: remove irq_count and do_softirq_own_stack()

sysrq_handle_reboot() re-enables interrupts while on the irq stack. The
irq_stack implementation wrongly assumed this would only ever happen
via the softirq path, allowing it to update irq_count late, in
do_softirq_own_stack().

This means if an irq occurs in sysrq_handle_reboot(), during
emergency_restart() the stack will be corrupted, as irq_count wasn't
updated.

Lose the optimisation, and instead of moving the adding/subtracting of
irq_count into irq_stack_entry/irq_stack_exit, remove it, and compare
sp_el0 (struct thread_info) with sp & ~(THREAD_SIZE - 1). This tells us
if we are on a task stack, if so, we can safely switch to the irq stack.
Finally, remove do_softirq_own_stack(), we don't need it anymore.

Reported-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: James Morse <james.morse@arm.com>
[will: use get_thread_info macro]
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/include/asm/irq.h
arch/arm64/kernel/entry.S
arch/arm64/kernel/irq.c