projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 58c09e2) | patch
tpm: Remove redundant dev_set_drvdata
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Sat, 5 Oct 2013 17:40:19 +0000 (11:40 -0600)
committerPeter Huewe <peterhuewe@gmx.de>
Tue, 22 Oct 2013 17:42:35 +0000 (19:42 +0200)
commitd0a40174efb0b9d232ccd1cf127cb90a2120f55b
tree7d86946113fb9c444e1f50583515181b92c7f11etree | snapshot (tar.gz zip)
parent58c09e21332c4ab56ac694a71f6715db2768f53fcommit | diff
tpm: Remove redundant dev_set_drvdata

TPM drivers should not call dev_set_drvdata (or aliases), only the core
code is allowed to call dev_set_drvdata, and it does it during
tpm_register_hardware.

These extra sets are harmless, but are an anti-pattern that many drivers
have copied.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: Joel Schopp <jschopp@linux.vnet.ibm.com>
Reviewed-by: Peter Huewe <peterhuewe@gmx.de>
Acked-by: Ashley Lai <adlai@linux.vnet.ibm.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
drivers/char/tpm/tpm_i2c_infineon.c diff | blob | blame | history
drivers/char/tpm/tpm_i2c_stm_st33.c diff | blob | blame | history
drivers/char/tpm/xen-tpmfront.c diff | blob | blame | history