ip_forward: Drop frames with attached skb->sk
authorSebastian Pöhn <sebastian.poehn@gmail.com>
Mon, 20 Apr 2015 07:19:20 +0000 (09:19 +0200)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:07:58 +0000 (13:07 +0000)
commitce89b805ca29fb1eb5b392f42a8406c7c66b31cd
treea171987c6426236371498f5f0f13ce6a00161e4a
parent96515fb8535db6caa267a75028c9ea8eba370dab
ip_forward: Drop frames with attached skb->sk

[ Upstream commit 2ab957492d13bb819400ac29ae55911d50a82a13 ]

Initial discussion was:
[FYI] xfrm: Don't lookup sk_policy for timewait sockets

Forwarded frames should not have a socket attached. Especially
tw sockets will lead to panics later-on in the stack.

This was observed with TPROXY assigning a tw socket and broken
policy routing (misconfigured). As a result frame enters
forwarding path instead of input. We cannot solve this in
TPROXY as it cannot know that policy routing is broken.

v2:
Remove useless comment

Signed-off-by: Sebastian Poehn <sebastian.poehn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/ip_forward.c