projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e1cc485) | patch
firmware: use 'kernel_read()' to read firmware into kernel buffer
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 4 Oct 2012 16:19:02 +0000 (09:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 4 Oct 2012 16:19:02 +0000 (09:19 -0700)
commitce57e981f2b996aaca2031003b3f866368307766
tree7ab6b29e6b0013519f3418bbaf8f661e064861batree | snapshot (tar.gz zip)
parente1cc485262846dcad931bf85ee655cbbb815bfe6commit | diff
firmware: use 'kernel_read()' to read firmware into kernel buffer

Fengguang correctly points out that the firmware reading should not use
vfs_read(), since the buffer is in kernel space.

The vfs_read() just happened to work for kernel threads, but sparse
warns about the incorrect address spaces, and it's definitely incorrect
and could fail for other users of the firmware loading.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/base/firmware_class.c diff | blob | blame | history