projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 35c036e) | patch
NFS: Cleanup error handling in nfs_idmap_request_key()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 20 Sep 2017 21:53:46 +0000 (00:53 +0300)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Sun, 1 Oct 2017 22:51:30 +0000 (18:51 -0400)
commitcdb2e53fd6dc715c5b45d0967fcb6dc574cb28f8
tree79c51cee65b7d0aca3c20d90c80e5cf474add959tree | snapshot (tar.gz zip)
parent35c036ef4a722e953e17884f4f4325f78eeab475commit | diff
NFS: Cleanup error handling in nfs_idmap_request_key()

nfs_idmap_get_desc() can't actually return zero.  But if it did then
we would return ERR_PTR(0) which is NULL and the caller,
nfs_idmap_get_key(), doesn't expect that so it leads to a NULL pointer
dereference.

I've cleaned this up by changing the "<=" to "<" so it's more clear that
we don't return ERR_PTR(0).

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
fs/nfs/nfs4idmap.c diff | blob | blame | history