net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given
authorFlorian Larysch <fl@n621.de>
Mon, 3 Apr 2017 14:46:09 +0000 (16:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 May 2017 04:19:52 +0000 (21:19 -0700)
commitcc5a5c09d32b8bd80477f45f12f47ca43536b19c
treebb425e7d5d09263f2887f7b2ae38f112ddd109f2
parent593e185eaadeefdc05a5e595428aec468646165a
net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

[ Upstream commit a8801799c6975601fd58ae62f48964caec2eb83f ]

inet_rtm_getroute synthesizes a skeletal ICMP skb, which is passed to
ip_route_input when iif is given. If a multipath route is present for
the designated destination, ip_multipath_icmp_hash ends up being called,
which uses the source/destination addresses within the skb to calculate
a hash. However, those are not set in the synthetic skb, causing it to
return an arbitrary and incorrect result.

Instead, use UDP, which gets no such special treatment.

Signed-off-by: Florian Larysch <fl@n621.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/route.c