tcp: Do not apply TSO segment limit to non-TSO packets
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 31 Dec 2014 13:39:23 +0000 (00:39 +1100)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:05:55 +0000 (13:05 +0000)
commitcb3529cfddb24fc046b63c777e305a9892ad625d
treede87dc753e4742e399f60ed22313aa48ae5841cd
parent675a04e4209de7bc07710c0fb00b560cfae7ad33
tcp: Do not apply TSO segment limit to non-TSO packets

[ Upstream commit 843925f33fcc293d80acf2c5c8a78adf3344d49b ]

Thomas Jarosch reported IPsec TCP stalls when a PMTU event occurs.

In fact the problem was completely unrelated to IPsec.  The bug is
also reproducible if you just disable TSO/GSO.

The problem is that when the MSS goes down, existing queued packet
on the TX queue that have not been transmitted yet all look like
TSO packets and get treated as such.

This then triggers a bug where tcp_mss_split_point tells us to
generate a zero-sized packet on the TX queue.  Once that happens
we're screwed because the zero-sized packet can never be removed
by ACKs.

Fixes: 1485348d242 ("tcp: Apply device TSO segment limit earlier")
Reported-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cheers,
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/tcp_output.c