net: ipv4: ip_forward: fix inverted local_df test
authorFlorian Westphal <fw@strlen.de>
Sun, 4 May 2014 21:24:31 +0000 (23:24 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 May 2014 19:26:09 +0000 (15:26 -0400)
commitca6c5d4ad216d5942ae544bbf02503041bd802aa
treeb1a3ebd37a8c9660cb2343f5f1dd8688b9de6782
parent4f4178f3bb1f470d7fb863ec531e08e20a0fd51c
net: ipv4: ip_forward: fix inverted local_df test

local_df means 'ignore DF bit if set', so if its set we're
allowed to perform ip fragmentation.

This wasn't noticed earlier because the output path also drops such skbs
(and emits needed icmp error) and because netfilter ip defrag did not
set local_df until couple of days ago.

Only difference is that DF-packets-larger-than MTU now discarded
earlier (f.e. we avoid pointless netfilter postrouting trip).

While at it, drop the repeated test ip_exceeds_mtu, checking it once
is enough...

Fixes: fe6cc55f3a9 ("net: ip, ipv6: handle gso skbs in forwarding path")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_forward.c