ext4: queue conversion after adding to inode's completed IO list
authorEric Sandeen <sandeen@redhat.com>
Thu, 28 Oct 2010 01:30:07 +0000 (21:30 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 28 Oct 2010 01:30:07 +0000 (21:30 -0400)
commitc999af2b347a55174f702702e0df814d05ef5491
tree47957b52c9a54babe4d8aefdda4f09cee5f76249
parent3e1e5f501632460184a98237d5460c521510535e
ext4: queue conversion after adding to inode's completed IO list

By queuing the io end on the unwritten workqueue before adding it
to our inode's list of completed IOs, I think we run the risk
of the work getting completed, and the IO freed, before we try
to add it to the inode's i_completed_io_list.

It should be safe to add it to the inode's list of completed
IOs, and -then- queue it for completion, I think.

Thanks to Dave Chinner for pointing out the race.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Jiaying Zhang <jiayingz@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/inode.c