FROMLIST: binder: fix memory corruption in binder_transaction binder
authorXu YiPing <xuyiping@hisilicon.com>
Mon, 22 May 2017 18:26:23 +0000 (11:26 -0700)
committerDanny Wood <danwood76@gmail.com>
Tue, 8 Oct 2019 13:46:27 +0000 (14:46 +0100)
commitc90ac0e20921c055f97bdcadacf3de590db3c058
treea2c71f314cc5bebc36cd166783435bc2d331d4dc
parent35852b611c5af888e0ac979391099fe2035a06be
FROMLIST: binder: fix memory corruption in binder_transaction binder

(from https://patchwork.kernel.org/patch/9939405/)

commit 7a4408c6bd3e ("binder: make sure accesses to proc/thread are
safe") made a change to enqueue tcomplete to thread->todo before
enqueuing the transaction. However, in err_dead_proc_or_thread case,
the tcomplete is directly freed, without dequeued. It may cause the
thread->todo list to be corrupted.

So, dequeue it before freeing.

Bug: 65333488
Change-Id: Id063a4db18deaa634f4d44aa6ebca47bea32537a
Signed-off-by: Xu YiPing <xuyiping@hisilicon.com>
Signed-off-by: Todd Kjos <tkjos@google.com>
drivers/android/binder.c