posix timers: sigqueue_free: don't free sigqueue if it is queued
authorOleg Nesterov <oleg@tv-sign.ru>
Mon, 26 May 2008 16:55:42 +0000 (20:55 +0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 26 May 2008 17:37:06 +0000 (10:37 -0700)
commitc8e85b4f4b9ee23bf0e79bdeb3da274a0f9c663f
tree5eadfdc177f24261379f36798c3366df9be4a00a
parent84a881657d391121cd88c37f0a312dec3528fa44
posix timers: sigqueue_free: don't free sigqueue if it is queued

Currently sigqueue_free() removes sigqueue from list, but doesn't cancel the
pending signal. This is not consistent, the task should either receive the
"full" signal along with siginfo_t, or it shouldn't receive the signal at all.

Change sigqueue_free() to clear SIGQUEUE_PREALLOC but leave sigqueue on list
if it is queued.

This is a user-visible change. If the signal is blocked, it stays queued
after sys_timer_delete() until unblocked with the "stale" si_code/si_value,
and of course it is still counted wrt RLIMIT_SIGPENDING which also limits
the number of posix timers.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Austin Clements <amdragon+kernelbugzilla@mit.edu>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/signal.c