projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a2fe37b) | patch
inet_diag: fix possible overflow in inet_diag_dump_one_icsk()
authorEric Dumazet <edumazet@google.com>
Fri, 13 Mar 2015 16:49:59 +0000 (09:49 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Mar 2015 19:54:27 +0000 (15:54 -0400)
commitc8e2c80d7ec00d020320f905822bf49c5ad85250
treefba6ff42961ccce00d9d070ac44c2d26e48258adtree | snapshot (tar.gz zip)
parenta2fe37b69d4fe369c284d50927193fed81c238a0commit | diff
inet_diag: fix possible overflow in inet_diag_dump_one_icsk()

inet_diag_dump_one_icsk() allocates too small skb.

Add inet_sk_attr_size() helper right before inet_sk_diag_fill()
so that it can be updated if/when new attributes are added.

iproute2/ss currently does not use this dump_one() interface,
this might explain nobody noticed this problem yet.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_diag.c diff | blob | blame | history