drm: Nuke drm_framebuffer->helper_private
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 10 Sep 2015 20:39:22 +0000 (22:39 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 11 Sep 2015 07:18:26 +0000 (09:18 +0200)
commitc86fb9d997428e0d55ab5a47488b6ba3bc4b5c5b
tree417d55fc1e4d6024bc3467d5869f1e20ff2d6d73
parentc099b55a6fa6f9ec2f26105c76df462d7c7c7d5b
drm: Nuke drm_framebuffer->helper_private

It's completely unused and there's really no reason for this:
- drm_framebuffer structures are invariant after creation, no need for
  helpers to manipulate them.
- drm_framebuffer structures should just be embedded (and that's what
  all the drivers do).

Stumbled over this since some folks are apparently concerned with the
overhead of struct drm_framebuffer and this is an easy 8 byte saving.

More could be gained by ditching the legacy fields and recomputing
stuff from the fourcc value. But that would require some drm-wide
cocci and real justification.

Cc: gary.k.smith@intel.com
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
include/drm/drm_crtc.h