netfilter: nf_log: fix error on write NONE to logger choice sysctl
authorPavel Tikhomirov <ptikhomirov@virtuozzo.com>
Fri, 1 Jul 2016 13:53:54 +0000 (16:53 +0300)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 5 Jul 2016 12:57:57 +0000 (14:57 +0200)
commitc6ac37d8d8843fb1fdc34e4a2a41a4f027ab670c
tree6c2fc97172f0b3d38ff59f2a06942bc6f0dc00c9
parentc37a2dfa67f7920b14ea77dc9f9f9660f7a1f6dd
netfilter: nf_log: fix error on write NONE to logger choice sysctl

It is hard to unbind nf-logger:

  echo NONE > /proc/sys/net/netfilter/nf_log/0
  bash: echo: write error: No such file or directory

  sysctl -w net.netfilter.nf_log.0=NONE
  sysctl: setting key "net.netfilter.nf_log.0": No such file or directory
  net.netfilter.nf_log.0 = NONE

You need explicitly send '\0', for instance like:

  echo -e "NONE\0" > /proc/sys/net/netfilter/nf_log/0

That seem to be strange, so fix it using proc_dostring.

Now it works fine:
   modprobe nfnetlink_log
   echo nfnetlink_log > /proc/sys/net/netfilter/nf_log/0
   cat /proc/sys/net/netfilter/nf_log/0
   nfnetlink_log
   echo NONE > /proc/sys/net/netfilter/nf_log/0
   cat /proc/sys/net/netfilter/nf_log/0
   NONE

v2: add missed error check for proc_dostring

Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_log.c