ethtool: make .get_dump_data() harder to misuse by drivers
authorMichal Schmidt <mschmidt@redhat.com>
Mon, 1 Jul 2013 15:23:30 +0000 (17:23 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Jul 2013 07:15:56 +0000 (00:15 -0700)
commitc590b5e2f05b5e98e614382582b7ae4cddb37599
treeee104276146080fdf350eeb7a5f6d9586c2e209c
parent8cc2d927c26a677415a9d0d23b9a043107f948c3
ethtool: make .get_dump_data() harder to misuse by drivers

As the patch "bnx2x: remove zeroing of dump data buffer" showed,
it is too easy implement .get_dump_data incorrectly in a driver.

Let's make sure drivers cannot get confused by userspace requesting
a too big dump.

Also WARN if the driver sets dump->len to something weird and make
sure the length reported to userspace is the actual length of data
copied to userspace.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c