Reinstate "drm/probe-helpers: Drop locking from poll_enable""
authorDave Airlie <airlied@redhat.com>
Fri, 27 Jan 2017 02:04:08 +0000 (12:04 +1000)
committerDave Airlie <airlied@redhat.com>
Fri, 27 Jan 2017 02:04:08 +0000 (12:04 +1000)
commitc4d79c22015564a9d922715434a0ec09d1deee30
tree0244663e07ce8575d6060d0f1dae9d8fef30e829
parentb0df0b251b25b0bf89ef3e518330fcac300add86
Reinstate "drm/probe-helpers: Drop locking from poll_enable""

This reverts commit 54a07c7bb0da0343734c78212bbe9f3735394962,
and reinstates the original.

[airlied: this might be a bad plan for git].

commit 3846fd9b86001bea171943cc3bb9222cb6da6b42
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Wed Jan 11 10:01:17 2017 +0100

    drm/probe-helpers: Drop locking from poll_enable

    It was only needed to protect the connector_list walking, see

    commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
    Author: Daniel Vetter <daniel.vetter@ffwll.ch>
    Date:   Thu Jul 9 23:44:26 2015 +0200

        drm/probe-helper: Grab mode_config.mutex in poll_init/enable

    Unfortunately the commit message of that patch fails to mention that
    the new locking check was for the connector_list.

    But that requirement disappeared in

    commit c36a3254f7857f1ad9badbe3578ccc92be541a8e
    Author: Daniel Vetter <daniel.vetter@ffwll.ch>
    Date:   Thu Dec 15 16:58:43 2016 +0100

        drm: Convert all helpers to drm_connector_list_iter

    and so we can drop this again.

    This fixes a locking inversion on nouveau, where the rpm code needs to
    re-enable. But in other places the rpm_get() calls are nested within
    the big modeset locks.

    While at it, also improve the kerneldoc for these two functions a
    notch.

    v2: Update the kerneldoc even more to explain that these functions
    can't be called concurrently, or bad things happen (Chris).
drivers/gpu/drm/drm_probe_helper.c
drivers/gpu/drm/i915/intel_hotplug.c
include/drm/drm_crtc_helper.h