batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation
authorSven Eckelmann <sven.eckelmann@openmesh.com>
Mon, 16 Mar 2020 22:30:18 +0000 (23:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Mar 2020 09:54:20 +0000 (10:54 +0100)
commitc408b35da8ef4378b858d3f9f33f23a16989676b
tree8b4324af04ac519efef62b7441564a3cfdf684f3
parent02f13e4e682390d10d7ece6260d9ee4059c8f450
batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation

commit 6a4bc44b012cbc29c9d824be2c7ab9eac8ee6b6f upstream.

The neighbor compare API implementation for B.A.T.M.A.N. V checks whether
the neigh_ifinfo for this neighbor on a specific interface exists. A
warning is printed when it isn't found.

But it is not called inside a lock which would prevent that this
information is lost right before batadv_neigh_ifinfo_get. It must therefore
be expected that batadv_v_neigh_(cmp|is_sob) might not be able to get the
requested neigh_ifinfo.

A WARN_ON for such a situation seems not to be appropriate because this
will only flood the kernel logs. The warnings must therefore be removed.

Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/bat_v.c