f_ncm: Don't use netdev_start_xmit().
authorDavid S. Miller <davem@davemloft.net>
Thu, 28 Aug 2014 00:05:53 +0000 (17:05 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Aug 2014 00:05:53 +0000 (17:05 -0700)
commitc2c0e8b2b88cac379b2a2167b448000dedd2596a
treede123ea72ffe5f4a6cdf160b8a2b7a135c0c516e
parent23d2d9a630b98a554cc328c6b69c56fd285e0129
f_ncm: Don't use netdev_start_xmit().

Unfortunately, the USB gadget layer has this weird things where NULL
skbs are passed into ops->ndo_start_xmit() in order to trigger the
dev->wrap() calls to build packets.

This is completely outside of the allowable range of sane arguments
for the ndo_start_xmit method.  All invocations of ndo_start_xmit()
should be with non-NULL SKB arguments.

Put back the direct call, but with a comment explaining how this
is not acceptable in the long term.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/usb/gadget/function/f_ncm.c