[SCSI] bnx2i : Fix "cid #n not valid" issue
authorAnil Veerabhadrappa <anilgv@broadcom.com>
Thu, 30 Jul 2009 04:50:11 +0000 (21:50 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Sat, 22 Aug 2009 22:52:12 +0000 (17:52 -0500)
commitc19dcd011238118ad07d3ab7ed1bbc4916826324
tree93c100d928f16f5ebd522e73c6ef43877f21a9a1
parent534cc9c165017dd29ae0f4458832893dc8033c6f
[SCSI] bnx2i : Fix "cid #n not valid" issue

When bnx2i_adapter_ready() fails, connection handle(cid) = 0 is wrongly freed
because 'cid' is not yet allocated for the endpoint.  Fix is to initialize
bnx2i_ep->ep_iscsi_cid to '-1' in bnx2i_alloc_ep() and not in
bnx2i_ep_connect() to avoid releasing invalid 'cid'.  There is already a check
in bnx2i_free_iscsi_cid() not to free invalid iscsi connection handle (-1)

Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/bnx2i/bnx2i_iscsi.c