autofs4 - fix get_next_positive_dentry()
authorIan Kent <raven@themaw.net>
Tue, 18 Jan 2011 04:06:04 +0000 (12:06 +0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 18 Jan 2011 06:21:26 +0000 (01:21 -0500)
commitc14cc63a63e94d490ac6517a555113c30d420db4
tree4769517c39eedbbeaedc7a73636d7c65c0de5a38
parent6845a44a314c0c626549de373131bf108f9cc1f1
autofs4 - fix get_next_positive_dentry()

The initialization condition in fs/autofs4/expire.c:get_next_positive_dentry()
appears to be incorrect. If prev == NULL I believe that root should be
returned.

Further down, at the current dentry check for it being simple_positive()
it looks like the d_lock for dentry p should be dropped instead of dentry
ret, otherwise when p is assinged to ret we end up with no lock on p and
a lost lock on ret, which leads to a deadlock.

Signed-off-by: Ian Kent <raven@themaw.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/autofs4/expire.c