gpio: msm: make msm_gpio.summary_irq signed for error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 7 Nov 2013 07:51:34 +0000 (10:51 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 25 Nov 2013 08:03:12 +0000 (09:03 +0100)
commitbfea603bc54c0a736d45bc60b188a8cdae9aaaa3
treeb43b1450150157203cfe891c3f9f91e9f1f746c1
parentd535922691fc026479fcc03e78ac3d931a54e75a
gpio: msm: make msm_gpio.summary_irq signed for error handling

There is a bug in msm_gpio_probe() where we do:

msm_gpio.summary_irq = platform_get_irq(pdev, 0);
if (msm_gpio.summary_irq < 0) {

The problem is that "msm_gpio.summary_irq" is unsigned so the error
handling doesn't work.  I've fixed it by making it signed.

Fixes: 43f68444bce7 ('gpio: msm: Add device tree and irqdomain support for gpio-msm-v2')

Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-msm-v2.c