MIPS: SEAD3: Introduce the use of the managed version of kzalloc
authorHimangi Saraogi <himangi774@gmail.com>
Tue, 20 May 2014 18:09:42 +0000 (23:39 +0530)
committerRalf Baechle <ralf@linux-mips.org>
Mon, 26 May 2014 14:06:35 +0000 (16:06 +0200)
commitbfb7971c30a3dbca1d3bbc3ada47d72a4ea688f9
tree6a0a7df43750aa1aa7514524f4a334ab6eb4271d
parentacd8bc1a70ffff39018cd5cd1977e20d0ffce8d3
MIPS: SEAD3: Introduce the use of the managed version of kzalloc

This patch moves data allocated using kzalloc to managed data allocated
using devm_kzalloc and cleans now unnecessary kfrees in probe and remove
functions. Also, the now unnecessary labels out_mem and out are done
away with. The error handling code is moved under if and return 0 is now
at the end of the function.

The following Coccinelle semantic patch was used for making the change:

@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
  .probe = probefn,
  .remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e, e1, e2;
@@
probefn(struct platform_device *pdev, ...) {
  <+...
- e = kzalloc(e1, e2)
+ e = devm_kzalloc(&pdev->dev, e1, e2)
  ...
?-kfree(e);
  ...+>
}

@rem depends on prb@
identifier platform.removefn;
expression e;
@@
removefn(...) {
  <...
- kfree(e);
  ...>
}

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Tested-by: Markos Chandras <markos.chandras@imgtec.com>
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/6977/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/mti-sead3/sead3-pic32-i2c-drv.c