[SCSI] pm8001: Fix bogus interrupt state flag issue.
authorSantosh Nayak <santoshprasadnayak@gmail.com>
Sun, 26 Feb 2012 13:33:30 +0000 (19:03 +0530)
committerJames Bottomley <JBottomley@Parallels.com>
Wed, 29 Feb 2012 22:49:55 +0000 (16:49 -0600)
commitbdaefbf580cd200ae3230b6aacd1f4f2dadb18e3
treed916cbf8b7cd029699875d0776193d81a7883d03
parentcd9b3d04b4cae6bdfd639e603649777f819ed783
[SCSI] pm8001: Fix bogus interrupt state flag issue.

Static checker is giving following warning:
" error: calling 'spin_unlock_irqrestore()' with bogus flags"

The code flow is as shown below:
process_oq() --> process_one_iomb --> mpi_sata_completion

In 'mpi_sata_completion'
the first call for 'spin_unlock_irqrestore()' is with flags=0,
which is as good as 'spin_unlock_irq()' ( unconditional interrupt
enabling).

So for better performance 'spin_unlock_irqrestore()' can be replaced
with 'spin_unlock_irq()' and 'spin_lock_irqsave()' can be replaced by
'spin_lock_irq()'.

Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
Acked-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/pm8001/pm8001_hwi.c