block: reinstate early return of -EOPNOTSUPP from blkdev_issue_discard
authorMike Snitzer <snitzer@redhat.com>
Thu, 5 May 2016 15:54:21 +0000 (11:54 -0400)
committerJens Axboe <axboe@fb.com>
Thu, 5 May 2016 19:03:26 +0000 (13:03 -0600)
commitbbd848e0fade51ae51dab86a0683069cef89953f
tree1f3a5d8107fe664a19ebddf4f656b0f50fe267b5
parenta21f2a3ec62abe2e06500d6550659a0ff5624fbb
block: reinstate early return of -EOPNOTSUPP from blkdev_issue_discard

Commit 38f25255330 ("block: add __blkdev_issue_discard") incorrectly
disallowed the early return of -EOPNOTSUPP if the device doesn't support
discard (or secure discard).  This early return of -EOPNOTSUPP has
always been part of blkdev_issue_discard() interface so there isn't a
good reason to break that behaviour -- especially when it can be easily
reinstated.

The nuance of allowing early return of -EOPNOTSUPP vs disallowing late
return of -EOPNOTSUPP is: if the overall device never advertised support
for discards and one is issued to the device it is beneficial to inform
the caller that discards are not supported via -EOPNOTSUPP.  But if a
device advertises discard support it means that at least a subset of the
device does have discard support -- but it could be that discards issued
to some regions of a stacked device will not be supported.  In that case
the late return of -EOPNOTSUPP must be disallowed.

Fixes: 38f25255330 ("block: add __blkdev_issue_discard")
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-lib.c