projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ce1807b) | patch
spi/i.MX: fix broken error handling for gpio_request
authorJohn Ogness <john.ogness@linutronix.de>
Tue, 24 Nov 2009 16:53:07 +0000 (16:53 +0000)
committerGrant Likely <grant.likely@secretlab.ca>
Wed, 9 Dec 2009 01:48:16 +0000 (18:48 -0700)
commitbbd050af0e2b7d77bfc959cf76219eb71c3b982a
tree9a4da1f3a330ecdc5c6bbba7494940d74376ce79tree | snapshot (tar.gz zip)
parentce1807b2e527979bd77d8a1a1768a6365f3febb5commit | diff
spi/i.MX: fix broken error handling for gpio_request

i.MX35-provided chipselects are represented using negative numbers. If
gpio_request() fails and the previous chipselect was a negative number,
the while loop is endless (i is never decremented).

Also, the error loop would never call gpio_free on chipselect[0].

And finally, the error message was missing an endline.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/spi/spi_imx.c diff | blob | blame | history