mac80211: free skb fraglist before freeing the skb
authorSara Sharon <sara.sharon@intel.com>
Sat, 15 Dec 2018 09:03:06 +0000 (11:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Jan 2019 09:01:01 +0000 (10:01 +0100)
commitbb2509c12bea9601f0637f815936e9562d3c3cbc
tree8f4833d5b6ea5c66610445e708cca45b8cd2800b
parentfb34793c9f380b99c9ce925ff2d4e6b7f5af32c8
mac80211: free skb fraglist before freeing the skb

[ Upstream commit 34b1e0e9efe101822e83cc62d22443ed3867ae7a ]

mac80211 uses the frag list to build AMSDU. When freeing
the skb, it may not be really freed, since someone is still
holding a reference to it.
In that case, when TCP skb is being retransmitted, the
pointer to the frag list is being reused, while the data
in there is no longer valid.
Since we will never get frag list from the network stack,
as mac80211 doesn't advertise the capability, we can safely
free and nullify it before releasing the SKB.

Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/mac80211/status.c