[SCSI] Revert "sg: checking sdp->detached isn't protected when open"
authorJames Bottomley <JBottomley@Parallels.com>
Fri, 25 Oct 2013 09:25:14 +0000 (10:25 +0100)
committerJames Bottomley <JBottomley@Parallels.com>
Fri, 25 Oct 2013 09:59:02 +0000 (10:59 +0100)
commitbafc8ad82d482f9ecb9111969a3fdcef366bf8cb
tree6e6ad87c84fd2b8d6d2a78c1c5c160db3a3e18c7
parentc0d3b9c29ed22d449481bcfac267a879034a3a5b
[SCSI] Revert "sg: checking sdp->detached isn't protected when open"

This reverts commit e32c9e6300e3af659cbfe45e90a1e7dcd3572ada.

This is one of four patches that was causing this bug

[  205.372823] ================================================
[  205.372901] [ BUG: lock held when returning to user space! ]
[  205.372979] 3.12.0-rc6-hw-debug-pagealloc+ #67 Not tainted
[  205.373055] ------------------------------------------------
[  205.373132] megarc.bin/5283 is leaving the kernel with locks still held!
[  205.373212] 1 lock held by megarc.bin/5283:
[  205.373285]  #0:  (&sdp->o_sem){.+.+..}, at: [<ffffffff8161e650>] sg_open+0x3a0/0x4d0

Cc: Vaughan Cao <vaughan.cao@oracle.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/sg.c