fscrypto: require write access to mount to set encryption policy
authorEric Biggers <ebiggers@google.com>
Thu, 8 Sep 2016 21:20:38 +0000 (14:20 -0700)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 10 Sep 2016 05:18:57 +0000 (01:18 -0400)
commitba63f23d69a3a10e7e527a02702023da68ef8a6d
treeef70ece0179f4d642e0b0b4d5f6aa6cfed7c9e74
parent002ced4be6429918800ce3e41d5cbc2d7c01822c
fscrypto: require write access to mount to set encryption policy

Since setting an encryption policy requires writing metadata to the
filesystem, it should be guarded by mnt_want_write/mnt_drop_write.
Otherwise, a user could cause a write to a frozen or readonly
filesystem.  This was handled correctly by f2fs but not by ext4.  Make
fscrypt_process_policy() handle it rather than relying on the filesystem
to get it right.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Cc: stable@vger.kernel.org # 4.1+; check fs/{ext4,f2fs}
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/crypto/policy.c
fs/ext4/ioctl.c
fs/f2fs/file.c
include/linux/fscrypto.h